Add language and new methods in Source #2
Conversation
| /** | ||
| * Get a page with a list of manga. | ||
| * | ||
| * @since extensions-lib 1.5 | ||
| * @param query the search query. | ||
| * @param filters the list of filters to apply. | ||
| * @param page the page number to retrieve. | ||
| */ | ||
| suspend fun getMangaList(query: String, filters: FilterList, page: Int): MangasPage = throw Exception("Stub!") |
There was a problem hiding this comment.
why a new search method in Source? what about getSearchManga
There was a problem hiding this comment.
the PR is towards the main branch which doesn't have getSearchManga but either way this is basically replacing it.
| @@ -21,6 +23,36 @@ interface Source { | |||
| */ | |||
| val name: String | |||
|
|
|||
| /** | |||
| * Represents an IETF BCP 47 compliant language tag. | |||
There was a problem hiding this comment.
do we need to specify regions and scripts in languages?
There was a problem hiding this comment.
This is just correctly representing what app expected for extensions to return and extensions were returning for lang property
There was a problem hiding this comment.
like pt-br, zh-Hant, zh-TW etc. are IETF BCP 47
There was a problem hiding this comment.
Do we need the API to be unambiguous? No, but it sounds like a good idea.
There was a problem hiding this comment.
I think @AwkwardPeak7 was under the impression that instead of en sources will need to specify en-us
There was a problem hiding this comment.
Considering the comment beneath mentions "all" as a legal tag, shouldn't that be one of the options together with MULTI and OTHER? Or at the very least mentioned in the same bulleted list?
There was a problem hiding this comment.
Antsy forgot to remove the comment when he removed ALL
AntsyLich
changed the title
| @@ -21,6 +23,36 @@ interface Source { | |||
| */ | |||
| val name: String | |||
|
|
|||
| /** | |||
| * Represents an IETF BCP 47 compliant language tag. | |||
There was a problem hiding this comment.
Do we need the API to be unambiguous? No, but it sounds like a good idea.
No description provided.